maedhroz commented on code in PR #3054: URL: https://github.com/apache/cassandra/pull/3054#discussion_r1459662806
########## src/java/org/apache/cassandra/index/sai/disk/SSTableKeyTracker.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.index.sai.disk; + +import org.apache.cassandra.index.sai.utils.PrimaryKey; + +public abstract class SSTableKeyTracker +{ + public PrimaryKey minKey; + public PrimaryKey maxKey; + public PrimaryKey minStaticKey; + public PrimaryKey maxStaticKey; + + public long maxSSTableRowId = -1; + + protected int count; + + protected void updateMinMaxKeys(PrimaryKey key) + { + // Data is written in primary key order. If a schema contains clustering keys, it may also contain static + // columns. We track the min and max static keys separately here so that we can pass them to the segment + // metadata for indexes on static columns. Review Comment: I more or less created `SSTableKeyTracker` to avoid duplicating this comment and logic... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
