pkolaczk commented on code in PR #3054:
URL: https://github.com/apache/cassandra/pull/3054#discussion_r1466756493
##########
src/java/org/apache/cassandra/index/sai/iterators/KeyRangeIntersectionIterator.java:
##########
@@ -77,7 +77,19 @@ protected PrimaryKey computeNext()
if (index != alreadyAvanced)
{
KeyRangeIterator range = ranges.get(index);
- PrimaryKey nextKey = nextOrNull(range, highestKey);
+ PrimaryKey nextKey = range.getCurrent();
+
+ // Note that we will either have a data model that
produces SKINNY primary keys or a data model
+ // that produces some combination of WIDE and STATIC
prikary keys.
+ if (nextKey.kind() == PrimaryKey.Kind.WIDE ||
nextKey.kind() == highestKey.kind())
+ // We can always skip if the target is of the same
kind or this range is non-static.
+ nextKey = nextOrNull(range, highestKey);
+ else if (nextKey.kind() == PrimaryKey.Kind.STATIC &&
nextKey.compareTo(highestKey) < 0)
+ // For a range of static keys, only skip if we'e
advanced to a new partition, and when we
+ // do, skip to an actual static key. We may otherwise
skip too far, as static row IDs always
+ // precede non-static ones in on-disk postings lists.
+ nextKey = nextOrNull(range, highestKey.toStatic());
+
if (nextKey == null || nextKey.compareTo(highestKey) > 0)
Review Comment:
What if `highestKey` is STATIC? It may mess up the algorithm if there are
other `WIDE` keys, because it would basically make this condition false, as
STATIC key == any wide keys in the same partition. So it could break
intersecting other wide keys within the partition.
I think this would manifest if we had 2 regular columns and intersect it
with a static column.
Fortunately the intersection clause limit = 2 would not allow it, but a user
can change it and allow more than 2 columns in an intersection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
