Mmuzaf commented on code in PR #2958: URL: https://github.com/apache/cassandra/pull/2958#discussion_r1460001543
########## src/java/org/apache/cassandra/db/virtual/proc/SystemViewAnnotationProcessor.java: ########## Review Comment: While the SystemViewAnnotationProcessor reduces the need for boilerplate code for some additional model classes, it does add complexity to the build scripts. This is a trade-off that we need to agree on. For me, keeping all the generated classes sounds slightly better than increasing the complexity of the build, as the build.xml is already quite large. Do you think it's better to remove the `SystemViewAnnotationProcessor` or is it better to keep it and move it to the path you've suggested? The rationale is here, option #1 from here. https://issues.apache.org/jira/browse/CASSANDRA-14572?focusedCommentId=17800171&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17800171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
