Mmuzaf commented on code in PR #2958:
URL: https://github.com/apache/cassandra/pull/2958#discussion_r1467771150
##########
build.xml:
##########
@@ -478,6 +481,35 @@
</exec>
</target>
+ <!-- Include annotation processor for VirtualTable -->
+ <property name="processor.build.classes"
value="${build.classes}/processor" />
+ <property name="processor.manifest"
value="${processor.build.classes}/MANIFEST.MF" />
+
+ <target name="annotation-processor-build" depends="init"
description="Build system view annotation processor">
+ <antcall target="_annotation_processor_build"/>
+ </target>
+
+ <target name="_annotation_processor_build">
+ <mkdir dir="${processor.build.classes}" />
+ <javac includes="**/virtual/proc/*.java"
+ destdir="${processor.build.classes}"
+ includeantruntime="true"
+ source="${java.default}" target="${java.default}">
+ <src path="${build.src}"/>
+ </javac>
+ </target>
+
+ <target name="annotation-processor-jar"
+ depends="annotation-processor-build">
+ <mkdir dir="${processor.build.classes}/META-INF" />
+ <jar
destfile="${build.dir.lib}/jars/cassandra-annotation-processor-${version}.jar">
+ <fileset dir="${processor.build.classes}"/>
+ <manifest>
+ <attribute name="Built-By" value="Maxim Muzafarov"/>
Review Comment:
I did it the same way with the other stuff in the build.xml, but yeah it
looks weird. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
