Mmuzaf commented on code in PR #3002: URL: https://github.com/apache/cassandra/pull/3002#discussion_r1462024042
########## src/java/org/apache/cassandra/cache/ICache.java: ########## @@ -23,6 +23,8 @@ * This is similar to the Map interface, but requires maintaining a given capacity * and does not require put or remove to return values, which lets SerializingCache * be more efficient by avoiding deserialize except on get. + * + * This class represents a weighted cache. Review Comment: There is also a cache called `ChunkCache' which also has a weighted type, but it doesn't extend the `ICache' interface. So, we either have to fix javadocs for both of these cases or for none of them. The latter case sounds more easy for me as the `CacheSize` already has description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
