Mmuzaf commented on code in PR #3002:
URL: https://github.com/apache/cassandra/pull/3002#discussion_r1462063901
##########
src/java/org/apache/cassandra/tools/NodeProbe.java:
##########
@@ -1748,22 +1749,22 @@ public Object getCacheMetric(String cacheType, String
metricName)
case "HitRate":
case "Size":
return JMX.newMBeanProxy(mbeanServerConn,
- new
ObjectName("org.apache.cassandra.metrics:type=Cache,scope=" + cacheType +
",name=" + metricName),
-
CassandraMetricsRegistry.JmxGaugeMBean.class).getValue();
+ new
ObjectName("org.apache.cassandra.metrics:type=" + type + ",scope=" + scope +
",name=" + metricName),
+
CassandraMetricsRegistry.JmxGaugeMBean.class).getValue();
case "Requests":
case "Hits":
case "Misses":
return JMX.newMBeanProxy(mbeanServerConn,
- new
ObjectName("org.apache.cassandra.metrics:type=Cache,scope=" + cacheType +
",name=" + metricName),
-
CassandraMetricsRegistry.JmxMeterMBean.class).getCount();
+ new
ObjectName("org.apache.cassandra.metrics:type=" + type + ",scope=" + scope +
",name=" + metricName),
+
CassandraMetricsRegistry.JmxMeterMBean.class).getCount();
case "MissLatency":
return JMX.newMBeanProxy(mbeanServerConn,
- new
ObjectName("org.apache.cassandra.metrics:type=Cache,scope=" + cacheType +
",name=" + metricName),
-
CassandraMetricsRegistry.JmxTimerMBean.class).getMean();
+ new
ObjectName("org.apache.cassandra.metrics:type=" + type + ",scope=" + scope +
",name=" + metricName),
+
CassandraMetricsRegistry.JmxTimerMBean.class).getMean();
case "MissLatencyUnit":
return JMX.newMBeanProxy(mbeanServerConn,
- new
ObjectName("org.apache.cassandra.metrics:type=Cache,scope=" + cacheType +
",name=MissLatency"),
-
CassandraMetricsRegistry.JmxTimerMBean.class).getDurationUnit();
+ new
ObjectName("org.apache.cassandra.metrics:type=" + type + ",scope=" + scope +
",name=MissLatency"),
Review Comment:
Should we change `name=MissLatency` to `name=MissLatencyUnit` or am I
missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
