smiklosovic commented on code in PR #3085:
URL: https://github.com/apache/cassandra/pull/3085#discussion_r1478666916
##########
src/java/org/apache/cassandra/auth/AllowAllAuthenticator.java:
##########
@@ -22,13 +22,17 @@
import java.util.Map;
import java.util.Set;
+import com.google.common.collect.Sets;
+
import org.apache.cassandra.exceptions.AuthenticationException;
import org.apache.cassandra.exceptions.ConfigurationException;
public class AllowAllAuthenticator implements IAuthenticator
{
private static final SaslNegotiator AUTHENTICATOR_INSTANCE = new
Negotiator();
+ private static final Set<String> MODES =
Sets.newHashSet(AuthenticatedUser.ANONYMOUS_USERNAME);
Review Comment:
it feels strange to me to reuse "anonymous user name" for something like
authentication modes. I know that "well it is 'anonymous' and we need that
constant' but we should not reuse that even it is of same value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
