smiklosovic commented on code in PR #3085:
URL: https://github.com/apache/cassandra/pull/3085#discussion_r1478669962
##########
src/java/org/apache/cassandra/auth/AuthenticatedUser.java:
##########
@@ -33,10 +35,10 @@
public class AuthenticatedUser
{
public static final String SYSTEM_USERNAME = "system";
- public static final AuthenticatedUser SYSTEM_USER = new
AuthenticatedUser(SYSTEM_USERNAME);
+ public static final AuthenticatedUser SYSTEM_USER = new
AuthenticatedUser(SYSTEM_USERNAME, SYSTEM_USERNAME);
Review Comment:
again, using same constant for "authentication mode" just feels strange.
What has _username_ common with _authentication mode_ except it is of same
value? We should have an enum where all possible authentication modes are and
we should reference it here, not reusing already existing constants for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
