tolbertam commented on code in PR #3085:
URL: https://github.com/apache/cassandra/pull/3085#discussion_r1479140313
##########
src/java/org/apache/cassandra/db/virtual/ClientsTable.java:
##########
@@ -86,7 +90,9 @@ public DataSet data()
.column(SSL_ENABLED, client.sslEnabled())
.column(SSL_PROTOCOL, client.sslProtocol().orElse(null))
.column(SSL_CIPHER_SUITE,
client.sslCipherSuite().orElse(null))
- .column(KEYSPACE_NAME, client.keyspace().orElse(null));
+ .column(KEYSPACE_NAME, client.keyspace().orElse(null))
+ .column(MODE, client.mode().orElse(null))
+ .column(METADATA, client.metadata().orElse(null));
Review Comment:
Hrmm, yeah thats a good point. I'll make this non-optional, these values
should be NonNull, so they don't really need to be optional, i'll fix that all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
