tolbertam commented on code in PR #3085:
URL: https://github.com/apache/cassandra/pull/3085#discussion_r1479150323
##########
src/java/org/apache/cassandra/db/virtual/ClientsTable.java:
##########
@@ -86,7 +90,9 @@ public DataSet data()
.column(SSL_ENABLED, client.sslEnabled())
.column(SSL_PROTOCOL, client.sslProtocol().orElse(null))
.column(SSL_CIPHER_SUITE,
client.sslCipherSuite().orElse(null))
- .column(KEYSPACE_NAME, client.keyspace().orElse(null));
+ .column(KEYSPACE_NAME, client.keyspace().orElse(null))
+ .column(MODE, client.mode().orElse(null))
+ .column(METADATA, client.metadata().orElse(null));
Review Comment:
ah, just realized why I did this. There is code in
`ConnectedClient.getUser()` which seems to imply that it is not assured that
`ClientState.getUser()` will return a non-null value. Just to simplify this a
bit, I think we can just provide default values (UNAUTHENTICATED and empty map)
to not have to reason about optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
