tolbertam commented on code in PR #3109:
URL: https://github.com/apache/cassandra/pull/3109#discussion_r1491820947
##########
src/java/org/apache/cassandra/auth/MutualTlsAuthenticator.java:
##########
@@ -87,6 +101,18 @@ public MutualTlsAuthenticator(Map<String, String>
parameters)
}
certificateValidator = ParameterizedClass.newInstance(new
ParameterizedClass(certificateValidatorClassName),
Arrays.asList("", AuthConfig.class.getPackage().getName()));
+
+ String maxCertificateAgeConfig =
parameters.get(MAX_CERTIFICATE_AGE_CONFIG);
Review Comment:
One thing i'm wondering is whether the parameter should be on the
authenticator or in the validator.
I noticed that the certificate age itself is evaluated in
`SpiffeCertificateValidator`. Since we use `ParameterizedClass` on
`validator_class_name`, technically we should be able to pass parameters to it.
If you pass the parameter to the validator, then you don't need logic in
both `MutualTlsAuthenticator` and `MutualTlsInternodeAuthenticator` for parsing
out the certificate age.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
