frankgh commented on code in PR #3109:
URL: https://github.com/apache/cassandra/pull/3109#discussion_r1491828414


##########
src/java/org/apache/cassandra/auth/MutualTlsAuthenticator.java:
##########
@@ -87,6 +101,18 @@ public MutualTlsAuthenticator(Map<String, String> 
parameters)
         }
         certificateValidator = ParameterizedClass.newInstance(new 
ParameterizedClass(certificateValidatorClassName),
                                                               
Arrays.asList("", AuthConfig.class.getPackage().getName()));
+
+        String maxCertificateAgeConfig = 
parameters.get(MAX_CERTIFICATE_AGE_CONFIG);

Review Comment:
   yeah good point, I think there's more value in moving the validation out of 
the validator.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to