maedhroz commented on code in PR #2935:
URL: https://github.com/apache/cassandra/pull/2935#discussion_r1496337799
##########
src/java/org/apache/cassandra/db/filter/RowFilter.java:
##########
@@ -136,7 +177,66 @@ public boolean hasExpressionOnClusteringOrRegularColumns()
return false;
}
- protected abstract Transformation<BaseRowIterator<?>> filter(TableMetadata
metadata, long nowInSec);
+ protected Transformation<BaseRowIterator<?>> filter(TableMetadata
metadata, long nowInSec)
Review Comment:
I think that what we'll see in
[CASSANDRA-19007](https://issues.apache.org/jira/browse/CASSANDRA-19007) is
this method becoming parameterized to handle the situation where we're hitting
it from `ReadCommand#executeLocally()` (for normal, non-indexed AF queries). I
can add a brief message here mentioning that 19007 will fix it, but that for
now it ignores `isStrict()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
