adelapena commented on code in PR #2935:
URL: https://github.com/apache/cassandra/pull/2935#discussion_r1497522695
##########
src/java/org/apache/cassandra/service/reads/ReplicaFilteringProtection.java:
##########
@@ -197,6 +198,9 @@ public UnfilteredRowIterators.MergeListener
getRowMergeListener(DecoratedKey par
for (int i = 0; i < sources.size(); i++)
builders.add(i, new PartitionBuilder(partitionKey,
sources.get(i), columns, stats));
+ boolean[] silentRowAt = new boolean[builders.size()];
+ boolean[] silentColumnAt = new boolean[builders.size()];
Review Comment:
The class JavaDoc talks about silent rows (`the rows in a replica response
that don't have a corresponding row in other replica responses`). We should
probably update that also to mention the new silent columns.
##########
src/java/org/apache/cassandra/service/reads/DataResolver.java:
##########
@@ -306,7 +310,10 @@ private PartitionIterator resolveInternal(ResolveContext
context,
UnfilteredPartitionIterator merged =
UnfilteredPartitionIterators.merge(results, mergeListener);
Filter filter = new Filter(command.nowInSec(),
command.metadata().enforceStrictLiveness());
FilteredPartitions filtered = FilteredPartitions.filter(merged,
filter);
- PartitionIterator counted =
Transformation.apply(preCountFilter.apply(filtered),
context.mergedResultCounter);
+
+ PartitionIterator counted = preCountFilter == null
Review Comment:
Nit: can we mark the `preCountFilter` parameter as `@Nullable`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
