smiklosovic commented on code in PR #3121: URL: https://github.com/apache/cassandra/pull/3121#discussion_r1498992496
########## .circleci/generate.sh: ########## @@ -80,15 +81,18 @@ print_help() all=false free=false paid=false +dedup=false Review Comment: all good but ... just semantics, shouldnt we rename this to "development" or something like that? I know it _deduplicates_, I just think it is better if we call it like what it is good for rather than what it does. I think that all the naming can stay and we would just document "-d" flag as "development", up to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
