ekaterinadimitrova2 commented on code in PR #3121:
URL: https://github.com/apache/cassandra/pull/3121#discussion_r1499991606
##########
.circleci/generate.sh:
##########
@@ -332,8 +336,72 @@ delete_repeated_jobs()
fi
}
+# Define function to leave only a single config run for each test group
+# The first and only argument is the file name.
Review Comment:
Maybe we mention in the comment also that this will be used during dev, not
pre-commit?
##########
.circleci/generate.sh:
##########
@@ -332,8 +336,72 @@ delete_repeated_jobs()
fi
}
+# Define function to leave only a single config run for each test group
+# The first and only argument is the file name.
+dedup_jobs()
+{
+ delete_job "$1" "j11_cqlsh_dtests_py311_offheap"
Review Comment:
I have a small preference for replacing all these deletions of particular
jobs with something that would delete everything except particular jobs the
other way around. Otherwise, I can see how people will start adding new jobs to
the workflows without thinking whether they should be in the skinny workflow.
Also, the list will be smaller and less prone to merge conflicts, etc. However,
I leave it to you, @bereng, to decide whether you want to change this. Not a
blocker here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
