aweisberg commented on code in PR #80:
URL: https://github.com/apache/cassandra-accord/pull/80#discussion_r1501088133
##########
accord-core/src/main/java/accord/primitives/Txn.java:
##########
@@ -96,34 +108,64 @@ enum Kind
*
* Invisible to other transactions.
*/
- ExclusiveSyncPoint,
+ ExclusiveSyncPoint('X'),
+
+ /**
+ * Used for local book-keeping only, not visible to any other replica
or directly to other transactions.
+ * This is used to create pseudo transactions that take the place of
dependencies that will be fulfilled by a bootstrap.
+ */
+ LocalOnly;
- LocalOnly
- ;
+ Kind()
+ {
+ this.shortName = name().charAt(0);
+ }
+
+ Kind(char shortName)
+ {
+ this.shortName = shortName;
+ }
public enum Kinds implements Predicate<Kind>
{
- Ws, RorWs, WsOrSyncPoint, SyncPoints, AnyGlobal, Any;
+ Nothing,
+ Ws,
Review Comment:
OK, I was also confused because I was thinking that comment was intended to
apply to all the `Kinds` below the comment, but it only applies to `RorWs`.
The positioning of the comment makes it seem like everything above it
witnesses ephemeral reads and everything below does not. In reality everything
doesn't witness them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
