aweisberg commented on code in PR #80:
URL: https://github.com/apache/cassandra-accord/pull/80#discussion_r1501078904
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -430,6 +430,22 @@ private static void
stableRecipientLocalSyncPoint(SafeCommandStore safeStore, Tx
safeStore.notifyListeners(safeCommand);
}
+ public static void stableEphemeralRead(SafeCommandStore safeStore,
SafeCommand safeCommand, Route<?> route, TxnId txnId, PartialTxn partialTxn,
PartialDeps partialDeps)
+ {
+ // TODO (expected): introduce in-memory only commands
+ Command command = safeCommand.current();
+ if (command.hasBeen(Stable))
+ return;
+
+ Ranges coordinateRanges = coordinateRanges(safeStore, txnId);
+ // TODO (desired, consider): in the case of sync points, the
coordinator is unlikely to be a home shard, do we mind this? should document at
least
+ ProgressShard progressShard = No;
+ Invariants.checkState(validate(command.status(), command,
Ranges.EMPTY, coordinateRanges, progressShard, route, Set, partialTxn, Set,
partialDeps, Set));
+ CommonAttributes attrs = set(safeStore, command, command,
Ranges.EMPTY, coordinateRanges, progressShard, route, partialTxn, Set,
partialDeps, Set);
+ safeCommand.stable(attrs, Ballot.ZERO, txnId,
initialiseWaitingOn(safeStore, txnId, Timestamp.MAX, attrs.partialDeps(),
route));
Review Comment:
I think here is where the `executeAt` needs to be instead of the txnid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
