jacek-lewandowski commented on code in PR #3164:
URL: https://github.com/apache/cassandra/pull/3164#discussion_r1519690353
##########
src/java/org/apache/cassandra/db/Directories.java:
##########
@@ -685,6 +719,28 @@ public static File getBackupsDirectory(File location)
}
}
+ /**
+ * Returns directory to write a backup to. If directory does not exist,
then it is NOT created.
+ *
+ * If given {@code location} indicates secondary index, this will return
+ * {@code <cf dir>/backups/.<index name>}.
+ * Otherwise, this will return {@code <cf dir>/backups/}.
+ *
+ * @param location base directory
+ * @return directory to write a backup
+ */
+ public static Optional<File> getBackupsDirectoryIfExists(File location)
Review Comment:
I know it is probably unrelated or too late but I don't really like the fact
that the table's directory structure leaks outside the `Descriptor` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
