smiklosovic commented on code in PR #3164:
URL: https://github.com/apache/cassandra/pull/3164#discussion_r1519701326
##########
src/java/org/apache/cassandra/db/Directories.java:
##########
@@ -673,6 +697,16 @@ public static File getBackupsDirectory(Descriptor desc)
return getBackupsDirectory(desc.directory);
}
+ /**
+ * Returns directory to write a backup to. If directory does not exist,
then one is created.
+ *
+ * If given {@code location} indicates secondary index, this will return
+ * {@code <cf dir>/backups/.<index name>}.
+ * Otherwise, this will return {@code <cf dir>/backups/}.
+ *
+ * @param location base directory
+ * @return directory to write a backup
+ */
public static File getBackupsDirectory(File location)
Review Comment:
we already talked about this with @blambov , we know it is, but it is too
late to do anything about that because it is public and god knows how people
use this so we on purpose left it as it was
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
