smiklosovic commented on code in PR #3180:
URL: https://github.com/apache/cassandra/pull/3180#discussion_r1531938518
##########
src/java/org/apache/cassandra/hints/HintsWriter.java:
##########
@@ -259,7 +261,7 @@ void append(Hint hint) throws IOException
if (hintBuffer == buffer)
bytesWritten += totalSize;
else
- append((ByteBuffer) hintBuffer.flip());
Review Comment:
not necessary
##########
src/java/org/apache/cassandra/hints/HintsWriter.java:
##########
@@ -224,7 +226,7 @@ void append(ByteBuffer hint) throws IOException
* Serializes and appends the hint (with CRC included) to this
session's aggregation buffer,
* writes to the underlying channel when the buffer is overflown.
*
- * Used mainly by tests and {@link LegacyHintsMigrator}
Review Comment:
does not exist anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
