iamaleksey commented on code in PR #3180:
URL: https://github.com/apache/cassandra/pull/3180#discussion_r1531955613
##########
src/java/org/apache/cassandra/hints/HintsDescriptor.java:
##########
@@ -81,18 +81,26 @@ final class HintsDescriptor
final UUID hostId;
final int version;
final long timestamp;
+ final String hintsFileName;
+ final String crc32FileName;
final ImmutableMap<String, Object> parameters;
final ParameterizedClass compressionConfig;
private final Cipher cipher;
private final ICompressor compressor;
+ // size of underlying hint file (without descriptor header and crc file
sizes)
+ // the value is populated in Session's close method in HintsWriter
+ volatile long size = 0;
Review Comment:
`size` -> `fileSize` slightly more descriptive. May also mark it as
`transient`, to borrow the Accord convention (for the reader, not for the JVM).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
