sarankk commented on code in PR #102:
URL: https://github.com/apache/cassandra-sidecar/pull/102#discussion_r1536096370
##########
src/test/java/org/apache/cassandra/sidecar/server/ServerSSLTest.java:
##########
@@ -124,6 +123,7 @@ void tearDown() throws InterruptedException
void failsWhenKeyStoreIsNotConfigured()
{
builder.sslConfiguration(SslConfigurationImpl.builder().enabled(true).build());
+ vertx = vertx();
Review Comment:
Since now creating a Vert.x instance needs `SidecarConfiguration` to get
metrics options. Changed this. Because in these tests, the configuration is
updated inside test as per each test. After the configuration update, building
the vert.x instance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
