yifan-c commented on code in PR #102:
URL: https://github.com/apache/cassandra-sidecar/pull/102#discussion_r1536281189
##########
src/main/java/org/apache/cassandra/sidecar/tasks/HealthCheckPeriodicTask.java:
##########
@@ -101,6 +108,11 @@ public void execute(Promise<Void> promise)
// join always waits until all its futures are completed and will not
fail as soon as one of the future fails
Future.join(futures)
+ .onComplete(v -> {
+ int instancesUp = instancesConfig.instances().size() -
instanceDown.get();
Review Comment:
`AtomicInteger instanceDown` provides better readability w/o perf sacrifice.
I am leaning to the current implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
