michaelsembwever commented on code in PR #3168:
URL: https://github.com/apache/cassandra/pull/3168#discussion_r1536822506
##########
src/java/org/apache/cassandra/schema/CompressionParams.java:
##########
@@ -530,7 +678,9 @@ public CompressionParams deserialize(DataInputPlus in, int
version) throws IOExc
options.put(key, value);
}
int chunkLength = in.readInt();
- int minCompressRatio = in.readInt();
+ int minCompressRatio = Integer.MAX_VALUE; // Earlier Cassandra
cannot use uncompressed chunks.
+ if (version >= MessagingService.VERSION_40)
+ minCompressRatio = in.readInt();
Review Comment:
same as above. i would think the `assert` is the correct way here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
