Claudenw commented on code in PR #3168:
URL: https://github.com/apache/cassandra/pull/3168#discussion_r1537117173
##########
src/java/org/apache/cassandra/cql3/statements/schema/CreateTableStatement.java:
##########
@@ -402,7 +401,7 @@ private void fixupCompactTable(List<ColumnProperties>
clusteringTypes,
if (hasCounters)
flags.add(TableMetadata.Flag.COUNTER);
- boolean isStaticCompact = !isDense && !isCompound;
+ boolean isStaticCompact = !isDense;
Review Comment:
```
boolean isDense = !clusteringTypes.isEmpty();
boolean isCompound = clusteringTypes.size() > 1;
```
if it is not dense then it is empty, and therefor it can not be compound.
isCompound is always false if isDense if false.
Removed to make logic more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
