bdeggleston commented on code in PR #3174:
URL: https://github.com/apache/cassandra/pull/3174#discussion_r1548324275
##########
src/java/org/apache/cassandra/repair/RepairJob.java:
##########
@@ -91,14 +99,24 @@ public class CassandraRepairJob extends AbstractRepairJob
* @param session RepairSession that this RepairJob belongs
* @param columnFamily name of the ColumnFamily to repair
*/
- public CassandraRepairJob(RepairSession session, String columnFamily)
+ public RepairJob(RepairSession session, String columnFamily)
{
- super(session, columnFamily);
this.ctx = session.ctx;
this.session = session;
this.taskExecutor = session.taskExecutor;
this.parallelismDegree = session.parallelismDegree;
this.desc = new RepairJobDesc(session.state.parentRepairSession,
session.getId(), session.state.keyspace, columnFamily,
session.state.commonRange.ranges);
+ this.ks = Keyspace.open(desc.keyspace);
+ this.cfs = ks.getColumnFamilyStore(columnFamily);
+ this.state = new JobState(ctx.clock(), desc,
session.state.commonRange.endpoints);
+
+ TableMetadata metadata = this.cfs.metadata();
+ if (session.paxosOnly && !metadata.supportsPaxosOperations())
+ throw new IllegalArgumentException(String.format("Cannot run paxos
only repair on %s.%s, which isn't configured for paxos operations",
cfs.keyspace.getName(), cfs.name));
Review Comment:
Added this check (and the others) to RepairCoordinator, though I'll leave
them here just in case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
