bdeggleston commented on code in PR #3174:
URL: https://github.com/apache/cassandra/pull/3174#discussion_r1548368644
##########
src/java/org/apache/cassandra/repair/RepairJob.java:
##########
@@ -163,19 +196,59 @@ public void onFailure(Throwable t)
return;
}
+ Future<Void> accordRepair;
+ if (doAccordRepair)
+ {
+ accordRepair = paxosRepair.flatMap(unused -> {
+ logger.info("{} {}.{} starting accord repair",
session.previewKind.logPrefix(session.getId()), desc.keyspace,
desc.columnFamily);
+ IPartitioner partitioner =
desc.ranges.iterator().next().left.getPartitioner();
+ AccordRepair repair = new AccordRepair(null, partitioner,
desc.keyspace, desc.ranges);
+ return repair.repair(taskExecutor);
+ }, taskExecutor);
+ }
+ else
+ {
+ accordRepair = paxosRepair.flatMap(unused -> {
+ logger.info("{} {}.{} not running accord repair",
session.previewKind.logPrefix(session.getId()), desc.keyspace,
desc.columnFamily);
+ return ImmediateFuture.success(null);
+ });
+ }
+
+ if (session.accordOnly)
+ {
+ accordRepair.addCallback(new FutureCallback<Void>()
+ {
+ public void onSuccess(Void ignored)
+ {
+ logger.info("{} {}.{} accord repair completed",
session.previewKind.logPrefix(session.getId()), desc.keyspace,
desc.columnFamily);
+ trySuccess(new RepairResult(desc, Collections.emptyList(),
ConsensusMigrationRepairResult.fromAccordOnlyRepair(repairStartingEpoch,
session.excludedDeadNodes)));
+ }
+
+ /**
+ * Snapshot, validation and sync failures are all handled here
Review Comment:
yeah looks like that was copied incorrectly when I did the initial paxos
repair work and kept copying it here :)
removed from both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
