krummas commented on code in PR #3234:
URL: https://github.com/apache/cassandra/pull/3234#discussion_r1555719325
##########
src/java/org/apache/cassandra/tcm/transformations/PrepareMove.java:
##########
@@ -67,6 +67,11 @@ public PrepareMove(NodeId nodeId,
this.streamData = streamData;
}
+ public NodeId nodeId()
Review Comment:
maybe mark VisibleForTesting
##########
src/java/org/apache/cassandra/tcm/MetadataKeys.java:
##########
@@ -52,4 +60,44 @@ public static MetadataKey make(String...parts)
return new MetadataKey(b.toString());
}
+ public static ImmutableSet<MetadataKey> diffKeys(ClusterMetadata before,
ClusterMetadata after)
+ {
+ ImmutableSet.Builder<MetadataKey> builder = new
ImmutableSet.Builder<>();
+ diffKeys(before, after, builder::add);
+ return builder.build();
+ }
+
+ private static void diffKeys(ClusterMetadata before, ClusterMetadata
after, Consumer<MetadataKey> consumer)
Review Comment:
this `Consumer` is always `builder::add`, could use that directly above
instead (and move the logic in this helper method there)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
