ifesdjeen commented on code in PR #3234:
URL: https://github.com/apache/cassandra/pull/3234#discussion_r1555755328
##########
src/java/org/apache/cassandra/tcm/MetadataKeys.java:
##########
@@ -52,4 +60,44 @@ public static MetadataKey make(String...parts)
return new MetadataKey(b.toString());
}
+ public static ImmutableSet<MetadataKey> diffKeys(ClusterMetadata before,
ClusterMetadata after)
+ {
+ ImmutableSet.Builder<MetadataKey> builder = new
ImmutableSet.Builder<>();
+ diffKeys(before, after, builder::add);
+ return builder.build();
+ }
+
+ private static void diffKeys(ClusterMetadata before, ClusterMetadata
after, Consumer<MetadataKey> consumer)
Review Comment:
I could yeah; i just had an follow-up patch that would also add checks for
cluster metadata equality / epoch bump, but I guess i can separate the two
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
