smiklosovic commented on code in PR #3240:
URL: https://github.com/apache/cassandra/pull/3240#discussion_r1558529985
##########
src/java/org/apache/cassandra/triggers/TriggerExecutor.java:
##########
@@ -220,6 +230,16 @@ private List<Mutation> executeInternal(PartitionUpdate
update)
Triggers triggers = update.metadata().triggers;
if (triggers.isEmpty())
return null;
+ Config.TriggersPolicy policy = DatabaseDescriptor.getTriggersPolicy();
Review Comment:
@aratno can't be this whole logic extracted to some method returning true /
false and a boolean field would be populated in this class so we do not need to
do this all over again every single time execute() method is called? That is
given if we give up on a guardrail.
at least DatabaseDescriptor.getTriggersPolicy() might be "cached" so we do
not need to call it all over again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
