smiklosovic commented on code in PR #3240:
URL: https://github.com/apache/cassandra/pull/3240#discussion_r1559157821
##########
src/java/org/apache/cassandra/triggers/TriggerExecutor.java:
##########
@@ -220,6 +230,16 @@ private List<Mutation> executeInternal(PartitionUpdate
update)
Triggers triggers = update.metadata().triggers;
if (triggers.isEmpty())
return null;
+ Config.TriggersPolicy policy = DatabaseDescriptor.getTriggersPolicy();
Review Comment:
yeah it would be a little bit hairy the other way ... we also do not have
access to `triggers` from `update.metadata().triggers` unless we loop over
`PartitionUpdate`s for the sake of using them in logger or exception upon
message construction.
Just to be explicit, so this would throw an exception on the first
`Mutation` and on the first `PartitionUpdate` of that mutation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
