beobal commented on code in PR #3197:
URL: https://github.com/apache/cassandra/pull/3197#discussion_r1559654670


##########
src/java/org/apache/cassandra/locator/LocalStrategy.java:
##########
@@ -53,4 +55,17 @@ public ReplicationFactor getReplicationFactor()
     {
         return RF;
     }
+
+    /**
+     * For lazy initialisation. In some circumstances, we may want to 
instantiate LocalStrategy without initialising
+     * DatabaseDescriptor; FQL replay is one such usage as we initialise the 
KeyspaceMetadata objects, which now eagerly
+     * creates the replication strategy.
+     */
+    static class EntireRange
+    {

Review Comment:
   That's a great idea and it is doable, but it will involve jumping through 
some hoops around static initialisation. I'd rather not start pulling on that 
thread here, so if it's ok we can file a follow up JIRA for that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to