beobal commented on code in PR #3197:
URL: https://github.com/apache/cassandra/pull/3197#discussion_r1559662270
##########
src/java/org/apache/cassandra/tcm/ClusterMetadataService.java:
##########
@@ -754,14 +752,9 @@ public MetadataSnapshots snapshotManager()
return snapshots;
}
- public ClusterMetadata sealPeriod()
+ public ClusterMetadata triggerSnapshot()
{
- return ClusterMetadataService.instance.commit(SealPeriod.instance,
- (ClusterMetadata
metadata) -> metadata,
- (code, reason) -> {
- // If the
transformation got rejected, someone else has beat us to seal this period
- return
ClusterMetadata.current();
- });
+ return
ClusterMetadataService.instance.commit(TriggerSnapshot.instance);
Review Comment:
Done in f16defd9791106a87098e6e1d58ad32c06dc59e9
##########
src/java/org/apache/cassandra/tcm/ownership/DataPlacement.java:
##########
@@ -25,19 +25,28 @@
import java.util.Objects;
import java.util.Set;
+import org.apache.cassandra.config.DatabaseDescriptor;
+import org.apache.cassandra.dht.IPartitioner;
import org.apache.cassandra.dht.Range;
import org.apache.cassandra.dht.Token;
import org.apache.cassandra.io.util.DataInputPlus;
import org.apache.cassandra.io.util.DataOutputPlus;
import org.apache.cassandra.locator.InetAddressAndPort;
+import org.apache.cassandra.locator.MetaStrategy;
import org.apache.cassandra.locator.Replica;
+import org.apache.cassandra.schema.ReplicationParams;
import org.apache.cassandra.tcm.Epoch;
import org.apache.cassandra.tcm.serialization.MetadataSerializer;
import org.apache.cassandra.tcm.serialization.Version;
public class DataPlacement
{
- public static final Serializer serializer = new Serializer();
+ private static final Serializer serializer = new
Serializer(DatabaseDescriptor.getPartitioner());
Review Comment:
Done in f16defd9791106a87098e6e1d58ad32c06dc59e9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
