blerer commented on code in PR #3095:
URL: https://github.com/apache/cassandra/pull/3095#discussion_r1567417585
##########
src/java/org/apache/cassandra/cql3/restrictions/ClusteringColumnRestrictions.java:
##########
@@ -219,12 +192,12 @@ public void addToRowFilter(RowFilter filter,
}
if (!restriction.isSlice())
- position = restriction.getLastColumn().position() + 1;
+ position = restriction.lastColumn().position() + 1;
}
}
private boolean handleInFilter(SingleRestriction restriction, int index)
{
- return restriction.isContains() || restriction.isLIKE() || index !=
restriction.getFirstColumn().position();
+ return restriction.needsFilteringOrIndexing() || index !=
restriction.firstColumn().position();
Review Comment:
Not exactly. The new one is correct. The old one I am not sure. I would have
to look into the details of each operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
