aweisberg commented on code in PR #3174:
URL: https://github.com/apache/cassandra/pull/3174#discussion_r1578265719
##########
src/java/org/apache/cassandra/repair/messages/RepairOption.java:
##########
@@ -313,21 +307,23 @@ else if (ranges.isEmpty())
private final boolean repairPaxos;
private final boolean paxosOnly;
- private final boolean accordRepair;
+ private final boolean accordOnly;
+ private final boolean isConsensusMigration;
Review Comment:
Totally reasonable. I think a comment somewhere explaining that consensus
migration wants to be highly available so it can occur at QUORUM while repair
wants to ensure visibility of data before the repair started at all replicas.
Really migration being highly available is just icing on the cake since we
can theoretically stay migrating indefinitely and it is fine. It just works
that way because it's additional work to add all which you have now done.
I think it's worth keeping just because we don't really know the downsides
of being in migration yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
