aweisberg commented on code in PR #3174:
URL: https://github.com/apache/cassandra/pull/3174#discussion_r1575060957
##########
src/java/org/apache/cassandra/repair/RepairCoordinator.java:
##########
@@ -282,12 +283,29 @@ public void run()
}
}
+ private void validate(RepairOption options)
+ {
+ if (options.paxosOnly() && options.accordOnly())
+ throw new IllegalArgumentException("Cannot specify a repair as
both paxos only and accord only");
+
+ for (ColumnFamilyStore cfs : columnFamilies)
+ {
+ TableMetadata metadata = cfs.metadata();
+ if (options.paxosOnly() && !metadata.supportsPaxosOperations())
+ throw new IllegalArgumentException(String.format("Cannot run
paxos only repair on %s.%s, which isn't configured for paxos operations",
cfs.keyspace.getName(), cfs.name));
+
+ if (options.accordOnly() && !metadata.requiresAccordSupport())
Review Comment:
Thinking a little harder about this being the `X only` case which is
unusual, it still seems like we shouldn't expose the need to determine which
ranges belong to which system outside of C*.
If you want to make this a TODO and file a JIRA we can kick the can down the
road on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
