maedhroz commented on code in PR #3267:
URL: https://github.com/apache/cassandra/pull/3267#discussion_r1585186787


##########
src/java/org/apache/cassandra/db/ColumnFamilyStore.java:
##########
@@ -545,7 +543,9 @@ public ColumnFamilyStore(Keyspace keyspace,
             indexManager.addIndex(info, true);
         }
 
-        metric = new TableMetrics(this, memtableMetrics);
+        // See CASSANDRA-16228. We need to ensure that metrics are exposed 
after the CFS is initialized,
+        // so the order of the following line is important and should not be 
moved.
+        metric = new TableMetrics(this);

Review Comment:
   Thanks for adding the comment ;)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to