maedhroz commented on code in PR #3267:
URL: https://github.com/apache/cassandra/pull/3267#discussion_r1585189634
##########
src/java/org/apache/cassandra/index/sai/metrics/ColumnQueryMetrics.java:
##########
@@ -97,6 +104,14 @@ public BalancedTreeIndexMetrics(IndexIdentifier
indexIdentifier)
postingsListener = new PostingListEventsMetrics(postingDecodes);
}
+ @Override
+ public void release()
+ {
+ super.release();
+ Metrics.remove(createMetricName("NumPostings",
BALANCED_TREE_POSTINGS_TYPE));
+ Metrics.remove(createMetricName("PostingDecodes",
BALANCED_TREE_POSTINGS_TYPE));
Review Comment:
nit: We could make constants out of "PostingDecodes" and "NumPostings" now,
I guess, since we use them multiple places, but not a big deal either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
