maedhroz commented on code in PR #3095:
URL: https://github.com/apache/cassandra/pull/3095#discussion_r1588561477
##########
src/java/org/apache/cassandra/cql3/restrictions/ClusteringColumnRestrictions.java:
##########
@@ -197,9 +170,9 @@ public boolean needFiltering()
return true;
if (!restriction.isSlice())
- position = restriction.getLastColumn().position() + 1;
+ position = restriction.lastColumn().position() + 1;
}
- return hasContains();
+ return false;
Review Comment:
So this is safe because `handleInFilter()` handles the "contains" case
anyway? (Was the `hasContains()` check actually redundant before, since
`handleInFilter()` returned `true` on the "contains" case?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
