dcapwell commented on code in PR #102:
URL: https://github.com/apache/cassandra-accord/pull/102#discussion_r1669027405
##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -1240,7 +1251,7 @@ public boolean equals(Object o)
if (!super.equals(o)) return false;
Executed executed = (Executed) o;
return Objects.equals(writes, executed.writes)
- && Objects.equals(result, executed.result);
+ && Objects.equals(result, executed.result); // TODO: find a
different way to check/assert?
Review Comment:
why this todo? what is the issue with the check?
##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -666,6 +672,11 @@ public final boolean isTruncated()
return status().hasBeen(Status.Truncated);
}
+ public static boolean isTruncated(Status status)
+ {
+ return status.hasBeen(Status.Truncated);
Review Comment:
```
Truncated (Cleanup, Maybe, DefinitionErased, ExecuteAtErased,
DepsErased, Outcome.Erased),
Invalidated (Persist, Maybe, NoOp, NoExecuteAt,
NoDeps, Outcome.Invalidated),
```
wouldn't that include `Invalidated`?
##########
accord-core/src/main/java/accord/local/Node.java:
##########
@@ -558,6 +558,9 @@ protected void start(BiConsumer<? super R, Throwable>
callback)
public void reply(Id replyingToNode, ReplyContext replyContext, Reply
send, Throwable failure)
{
+ if (replyingToNode == Id.NONE)
Review Comment:
when is this case in the protocol?
##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -1240,7 +1251,7 @@ public boolean equals(Object o)
if (!super.equals(o)) return false;
Executed executed = (Executed) o;
return Objects.equals(writes, executed.writes)
- && Objects.equals(result, executed.result);
+ && Objects.equals(result, executed.result); // TODO: find a
different way to check/assert?
Review Comment:
`TODO` should be `//TODO (classification 1, classification 2, etc.): msg`
This is so we can find them easier and find the *why* and *when* to fix
issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
