ifesdjeen commented on code in PR #102:
URL: https://github.com/apache/cassandra-accord/pull/102#discussion_r1675547822
##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -1240,7 +1251,7 @@ public boolean equals(Object o)
if (!super.equals(o)) return false;
Executed executed = (Executed) o;
return Objects.equals(writes, executed.writes)
- && Objects.equals(result, executed.result);
+ && Objects.equals(result, executed.result); // TODO: find a
different way to check/assert?
Review Comment:
Reverted this; this was a tmp TODO.
##########
accord-core/src/main/java/accord/local/Node.java:
##########
@@ -558,6 +558,9 @@ protected void start(BiConsumer<? super R, Throwable>
callback)
public void reply(Id replyingToNode, ReplyContext replyContext, Reply
send, Throwable failure)
{
+ if (replyingToNode == Id.NONE)
Review Comment:
Removed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
