dcapwell commented on code in PR #3416:
URL: https://github.com/apache/cassandra/pull/3416#discussion_r1674897618
##########
src/java/org/apache/cassandra/gms/FailureDetector.java:
##########
@@ -312,8 +312,8 @@ public boolean isAlive(InetAddressAndPort ep)
// registration via the metadata log, or a full gossip round).
This is perfectly harmless, so no need to log
// an error in that case.
ClusterMetadata metadata = ClusterMetadata.current();
- if (!metadata.directory.allJoinedEndpoints().contains(ep) &&
!metadata.fullCMSMembers().contains(ep))
- logger.error("Unknown endpoint: " + ep, new
IllegalArgumentException("Unknown endpoint: " + ep));
+// if (!metadata.directory.allJoinedEndpoints().contains(ep) &&
!metadata.fullCMSMembers().contains(ep))
Review Comment:
will add back, way too much spam in the test logs making it hard to find
*real* issues...
##########
src/java/org/apache/cassandra/schema/DistributedMetadataLogKeyspace.java:
##########
@@ -149,7 +149,8 @@ public static boolean tryCommit(Entry.Id entryId,
}
catch (Throwable t)
{
- logger.error("Caught an exception while trying to CAS", t);
+ //TODO (now): add back... it spams the logs making the real errors
get truncated
Review Comment:
will add back, way too much spam in the test logs making it hard to find
*real* issues...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
