dcapwell commented on code in PR #3416:
URL: https://github.com/apache/cassandra/pull/3416#discussion_r1674898411
##########
src/java/org/apache/cassandra/service/accord/AccordSafeCommandStore.java:
##########
@@ -246,28 +247,27 @@ private <O> O mapReduceForRange(Routables<?>
keysOrRanges, Ranges slice, BiFunct
{
if (commandsForRanges == null)
return accumulate;
+ CommandsForRanges cfr = commandsForRanges.current().slice(slice);
Review Comment:
this was found by `TopologyMixupTest`. The `CommandsForRanges` shows every
txn that could be found on *this* node, but we are processing a `Shard`, which
is a smaller range. So need to post process and `slice` to the shard's subset
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
