dcapwell commented on code in PR #3416: URL: https://github.com/apache/cassandra/pull/3416#discussion_r1674904770
########## test/distributed/org/apache/cassandra/distributed/impl/INodeProvisionStrategy.java: ########## @@ -26,140 +26,69 @@ import static org.apache.cassandra.utils.Shared.Recursive.INTERFACES; +//TODO (now, correctness): one network changes the port where as multiple network changes the address... yet AbstractNodeProvisionStrategy always changes the port too! @Shared(inner = INTERFACES) public interface INodeProvisionStrategy Review Comment: I need to double check things, I do think I caused a regression here... I did enough to get my test to do what I needed... I will need to look closer here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
