dcapwell commented on code in PR #3416:
URL: https://github.com/apache/cassandra/pull/3416#discussion_r1674903640
##########
test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java:
##########
@@ -1095,7 +1096,27 @@ public void close()
.filter(i -> !i.isShutdown())
.map(IInstance::shutdown)
.collect(Collectors.toList());
- FBUtilities.waitOnFutures(futures,1L, TimeUnit.MINUTES);
+ try
+ {
+ FBUtilities.waitOnFutures(futures,1L, TimeUnit.MINUTES);
+ }
+ catch (RuntimeException t)
+ {
+ if (t.getCause() instanceof TimeoutException)
Review Comment:
a timeout is really not useful as you don't have enough information to know
what happened... this will try to show what threads are left so you *could*
figure out what is blocked. This has been so helpful to find the threads that
are blocking!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
