yifan-c commented on code in PR #123:
URL: https://github.com/apache/cassandra-sidecar/pull/123#discussion_r1680466468
##########
src/main/java/org/apache/cassandra/sidecar/restore/RestoreJobManagerGroup.java:
##########
@@ -54,39 +52,32 @@ public RestoreJobManagerGroup(SidecarConfiguration
configuration,
ExecutorPools executorPools,
PeriodicTaskExecutor periodicTaskExecutor,
RestoreProcessor restoreProcessor,
- RestoreJobDiscoverer jobDiscoverer)
+ RestoreJobDiscoverer jobDiscoverer,
+ RingTopologyRefresher ringTopologyRefresher)
{
this.restoreJobConfig = configuration.restoreJobConfiguration();
this.restoreProcessor = restoreProcessor;
- this.jobDiscoverer = jobDiscoverer;
this.executorPools = executorPools;
initializeManagers(instancesConfig);
- jobDiscoverer.signalRefresh();
periodicTaskExecutor.schedule(jobDiscoverer);
periodicTaskExecutor.schedule(restoreProcessor);
+ periodicTaskExecutor.schedule(ringTopologyRefresher);
Review Comment:
It is not 0 cost to refresh the topology. My take is that until we find more
use cases, let's keep it scoped in the restore feature. At the end, the
refreshing requires "keyspace", which is provided in the restore jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
