yifan-c commented on code in PR #123:
URL: https://github.com/apache/cassandra-sidecar/pull/123#discussion_r1680473862
##########
src/main/java/org/apache/cassandra/sidecar/restore/RestoreJobManager.java:
##########
@@ -240,4 +245,10 @@ boolean isObsoleteRestoreJobDir(Path path)
long gapInMillis =
TimeUnit.DAYS.toMillis(restoreJobConfig.jobDiscoveryRecencyDays());
return delta > gapInMillis;
}
+
+ @VisibleForTesting
+ RestoreJobProgressTracker progressTrackerUnsafe(RestoreJob restoreJob)
Review Comment:
The method can changes the `jobs` states directly without going through the
intended path, i.e. `trySubmit`. It is used for testing. Having the "unsafe" in
the method name, in addition to the annotation, to make it more outstanding and
not invoke it in production code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
