ifesdjeen commented on code in PR #3431:
URL: https://github.com/apache/cassandra/pull/3431#discussion_r1684103589


##########
src/java/org/apache/cassandra/service/accord/AccordJournal.java:
##########
@@ -190,13 +160,57 @@ public AccordJournal start(Node node)
         Invariants.checkState(status == Status.INITIALIZED);
         this.node = node;
         status = Status.STARTING;
-        frameApplicator.start();
-        frameAggregator.start();
         journal.start();
+        this.delayedRequestProcessor.start();
         status = Status.STARTED;
         return this;
     }
 
+    @VisibleForTesting
+    public void replay()

Review Comment:
   This is an extremely early version. There's a bug in flusher: we do not seem 
to wait for last flush before we replay, which leads to some issues, so there's 
sleep here. But since this patch does not hook replay up to any prod code, I 
thought it would be fine to leave this in.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to