belliottsmith commented on code in PR #3431:
URL: https://github.com/apache/cassandra/pull/3431#discussion_r1686587805
##########
src/java/org/apache/cassandra/service/accord/AccordCommandStore.java:
##########
@@ -333,22 +331,32 @@ public AccordStateCache.Instance<Key, CommandsForKey,
AccordSafeCommandsForKey>
{
return commandsForKeyCache;
}
- Command loadCommand(TxnId txnId)
+
+ @Nullable
+ Runnable appendToKeyspace(Command before, Command after)
{
- return AccordKeyspace.loadCommand(this, txnId);
+ if (after.keysOrRanges() != null && after.keysOrRanges() instanceof
Keys)
+ return NO_OP;
Review Comment:
if we return `null` the cache won't waste time handing to another thread for
saving
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
